Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure retrying revision check on NotFound error #4092

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Ensure retrying revision check on NotFound error #4092

merged 1 commit into from
Dec 21, 2022

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Dec 21, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix the bug that Cloud Run deployment randomly exits with Revision Not Found message

knanao
knanao approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

khanhtc1202
khanhtc1202 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nghialv nghialv merged commit 5452ddb into master Dec 21, 2022
@nghialv nghialv deleted the cloudrun branch December 21, 2022 04:14
@github-actions github-actions bot mentioned this pull request Dec 21, 2022
Merged
knanao pushed a commit that referenced this pull request Dec 21, 2022
@nghialv @knanao
Ensure retrying revision check on NotFound error (#4092)
fc59b9c
@knanao knanao mentioned this pull request Dec 21, 2022
Merged
knanao added a commit that referenced this pull request Dec 21, 2022
@knanao @khanhtc1202 @nghialv
Cherry-pick #4091 #4092 #4093 (#4095)
9ab142f 
* Remove old version docs (#4091)

* Ensure retrying revision check on NotFound error (#4092)

* Release v0.41.1 (#4093)

* Release v0.41.1

* Update the release note

Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: nghialv <[email protected]>
This was referenced Jan 6, 2023
Merged
Merged
This was referenced Feb 7, 2023
Merged
Closed
@github-actions github-actions bot mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knanao knanao knanao approved these changes

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

Assignees
No one assigned
Labels
area/go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nghialv @khanhtc1202 @knanao